Assert compound values #1704
Merged
Assert compound values #1704
+22
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
approved these changes
Sep 9, 2024
axelboc
force-pushed
the
assert-compound
branch
from
dba5a60
to
2f951f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primitive<PrintableCompoundType>resolves to(string | number | boolean | H5WebComplex)[]but we weren't actually asserting for this fully inassertPrimitiveValue. I'm correcting this and also generalising things a bit:Primitive<CompoundType>tounknown[]instead ofunknown(to match the existing array assertion inassertPrimitiveValue)CompoundTypeto extendDTypeinstead ofRecord<string, DType>to simplify usage (notably when inferring the generic inPrimitive) and to remove the need forPrintableCompoundType(now replaced with justCompoundType<PrintableType>)