Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jitter when resizing explorer sidebar on Matrix vis #1712

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Sep 16, 2024

This fixes two jittering issues when resizing the explorer sidebar:

  • Some control labels would sometimes wrap onto two lines. I noticed this with the Cell width control on the Matrix vis, but the same could most likely happen with Selector labels. I now prevent wrapping in both cases.
  • The Matrix visualization would overflow and cause sidebars to appear and disappear quickly.
BEFORE AFTER
matrix-resize-jitter matrix-resize-jitter-fixed

Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@axelboc axelboc merged commit a25cbd6 into main Oct 2, 2024
8 checks passed
@axelboc axelboc deleted the fix-jitter branch October 2, 2024 08:04
@loichuder
Copy link
Member

I wish this would have been merged before the demo last week 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants