Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove needs to change Makefile and tgy.asm for a new board configuration #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msperl
Copy link

@msperl msperl commented Oct 19, 2015

Enabled automatic discovery of board includes in Makefile (removing manual list)
Removed the manually added board includes in tgy.asm (with a workarround for tgy.inc)
Made it possible (in principle) to use a different m*def.inc inside the .inc
Made some of the targets phony

Removed the manually added board includes in tgy.asm (with a workarround for tgy.inc)
Made it possible (in principle) to use a different m*def.inc inside the <board>.inc
@msperl
Copy link
Author

msperl commented Oct 19, 2015

This came up during a discussion in #96.
This may ease the "integration needs" for forked repositories - upstreaming additional *.inc becomes trivial

@@ -80,83 +91,6 @@
;
; The following only works with avra or avrasm2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments would be made unnecessary

@ahalekelly
Copy link
Contributor

My makefile skills aren't good enough to fully understand your code, but this is a great idea

@msperl
Copy link
Author

msperl commented Oct 23, 2015

Give the patch a try and see if it works for you...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants