Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigget the stop event on label click. #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dlopez-akalam
Copy link

This solves #120

Without this patch, if there is a stop event handler, the behavior is confusing because it works different when you drag the slider and when you click in the label.

@simeydotme
Copy link
Owner

oh thanks @dlopez-akalam !

question; Have you verified this doesn't cause any weirdness with animated sliders? In honesty it's been years since I worked with jQuery sliders and I cannot remember if the slider was set to animate whether it'll be affected with an abrupt .stop() trigger.

If you can do a quick jsfiddle of before/after without any regression then I'll be happy to merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants