-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ICU for better Unicode sorting #1066
base: master
Are you sure you want to change the base?
Conversation
We probably need a little test for this and a mention & example of it in the manual. Also, as previously discussed we are looking for someone on windows (and the other platforms) to test building this, we want to know if it makes installation harder. |
For the record, this improves the sorting of the new descriptions/payees/notes commands by making them case insensitive and “accent insensitive”, so that eg ã sorts similarly to a. It adds text-icu as a dependency, which requires the icu C library. |
The test I added was for a proposed bit that isn't implemented yet (account name sorting), I didn't add a test yet for the part I did implement (descriptions/payee/note sorting) ;-) |
What's needed to move this forward ? I think:
And if that works, then:
|
I think that summary is correct. When the time comes I'll be happy to take care of some of the other steps, but I don't have access to Windows to test on. |
c9b2bbd
to
ea9bddb
Compare
56bc295
to
01f9c70
Compare
This is an extract from #1063 with the ICU related bit separately for testing and review.
...and as long as its being run separately here there are probably a few other places that could take advantage of better Unicode support.
Additionally if there is a way (sorting flag?) to do phonetic interspersed sorting instead of per-alphabet that would be an interesting alternative as well.