Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ICU for better Unicode sorting #1066

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alerque
Copy link
Collaborator

@alerque alerque commented Jul 14, 2019

This is an extract from #1063 with the ICU related bit separately for testing and review.

...and as long as its being run separately here there are probably a few other places that could take advantage of better Unicode support.

Additionally if there is a way (sorting flag?) to do phonetic interspersed sorting instead of per-alphabet that would be an interesting alternative as well.

@simonmichael simonmichael changed the title Use ICU for better Unicode support Use ICU for better Unicode sorting Jul 15, 2019
@simonmichael
Copy link
Owner

We probably need a little test for this and a mention & example of it in the manual. Also, as previously discussed we are looking for someone on windows (and the other platforms) to test building this, we want to know if it makes installation harder.

@simonmichael simonmichael added A-WISH Some kind of improvement request, hare-brained proposal, or plea. help wanted needs:docs To unblock: needs corresponding documentation or doc updates needs:testing To unblock: needs more developer testing or general usage needs:tests To unblock: needs more automated tests or test updates platform:freebsd platform:linux platform:mac platform:nix platform:windows labels Jul 15, 2019
@alerque alerque self-assigned this Jul 15, 2019
@simonmichael simonmichael added the i18n Internationalisation/localisation-related. label Jul 15, 2019
@simonmichael
Copy link
Owner

For the record, this improves the sorting of the new descriptions/payees/notes commands by making them case insensitive and “accent insensitive”, so that eg ã sorts similarly to a. It adds text-icu as a dependency, which requires the icu C library.

@simonmichael simonmichael removed the needs:tests To unblock: needs more automated tests or test updates label Jul 15, 2019
@alerque alerque added help wanted needs:tests To unblock: needs more automated tests or test updates and removed help wanted labels Jul 15, 2019
@alerque
Copy link
Collaborator Author

alerque commented Jul 15, 2019

The test I added was for a proposed bit that isn't implemented yet (account name sorting), I didn't add a test yet for the part I did implement (descriptions/payee/note sorting) ;-)

@simonmichael
Copy link
Owner

What's needed to move this forward ? I think:

  • find someone to see if this builds on Windows.

And if that works, then:

  • clarify which commands are changed, mention the new sorting behaviour in their docs
  • consider what other commands to change for consistency
  • rebase these changes on latest master, and combine/clean up commits

@simonmichael simonmichael removed the needs:tests To unblock: needs more automated tests or test updates label Nov 19, 2019
@alerque
Copy link
Collaborator Author

alerque commented Nov 26, 2019

I think that summary is correct. When the time comes I'll be happy to take care of some of the other steps, but I don't have access to Windows to test on.

@simonmichael simonmichael force-pushed the master branch 6 times, most recently from 56bc295 to 01f9c70 Compare July 11, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-WISH Some kind of improvement request, hare-brained proposal, or plea. i18n Internationalisation/localisation-related. needs:docs To unblock: needs corresponding documentation or doc updates needs:testing To unblock: needs more developer testing or general usage platform:freebsd platform:linux platform:mac platform:nix platform:windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants