-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix connection issues #7
Open
davidjbradshaw
wants to merge
18
commits into
simonrauch:master
Choose a base branch
from
davidjbradshaw:polling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi thanks for creating this. I've been using it with my UHZ65 for a couple of months, but I've found that the connection between my projector and HomeBridge to be a bit intermittent and often times out. Issues #3 and #5 might be related to this as well.
I've made a few changes to make it recover silently when this happens, rather than throw an error at HomeKit. To achieve this I've made the following changes.
boot
/shutdown
messages in 1.5 seconds, drop connections, reopen and resend command.status
command once per second, this can be changed with the optionalpollInterval
config setting, this is mainly to stop the projector silently dropping the connection, but does also make getting status changes from the projector more robust as well.status
requests go unanswered, drop and reopen connection.In addition to this, I've added some extra logging and a
logLevel
to the config, with options foroff
,default
anddebug
. Finally I converted the Magic Numbers to consts at the top of the file and tidied a couple of bits to help me as I went through this.This was only meant to be a simple PR, but I seem to have rewritten about half the code and and expanded it by the same amount. I hope that is all OK.
Dave.