Skip to content

Conversation

LouisLeNezet
Copy link

Issue: closes #13657

Popularity metric: 352,254

image

Checklist

  • I have reviewed the forbidden brands list and confirm the brand I am submitting a PR for is not one of them, nor is it a subsidiary of one of those brands
  • I have reviewed the brand's terms of service, and am confident we can add this icon
  • I updated the JSON data in data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The Hex value is from the documentation.
I used inkscape to vectorize the png.
I only use the original source from Bioconductor/BiocStickers

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label Jul 24, 2025
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LouisLeNezet The failing CI needs to be fixed. You can read through our Optimize the Icon section to learn how to process the icon in the right way.

@LouisLeNezet LouisLeNezet requested a review from LitoMore July 25, 2025 14:35
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LouisLeNezet Stills failing. Better to test the code on your local before submitting.

@LouisLeNezet
Copy link
Author

@LitoMore Sorry, this is my first contribution and I didn't know how to run the test.
I've ran npm run lint --icons="icons/bioconductor.svg" --docs="" and npm run test on codespaces and they do seems to pass now.
However I had to use a precision of 4 on SVGO, because a value of 3 resized the icon to 23.999 instead of 24.

@LouisLeNezet LouisLeNezet requested a review from LitoMore July 25, 2025 15:43
@adamrusted adamrusted added permissions in review We are checking if permission is needed to include this icon. Take no action in the meantime. permission required Contact trademark owner for permission to include this icon. Take no other action in the meantime. and removed permissions in review We are checking if permission is needed to include this icon. Take no action in the meantime. labels Sep 14, 2025
@adamrusted
Copy link
Member

As per the guidelines page you linked to, we will need written permission to include this icon in our repository. Could you please reach out to them @LouisLeNezet?

@adamrusted adamrusted mentioned this pull request Sep 14, 2025
1 task
@mblue9
Copy link

mblue9 commented Sep 15, 2025

Thanks for submitting this! As Bioconductor Community Manager, I confirm that it's fine to proceed with including the Bioconductor logo. We've agreed to license it under CC-BY-SA 4.0, similar to the R logo.
(cc @vjcitn)

@adamrusted adamrusted added permission granted Explicit permission granted by trademark owner or company's legal terms for us to include this icon. and removed permission required Contact trademark owner for permission to include this icon. Take no other action in the meantime. labels Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon permission granted Explicit permission granted by trademark owner or company's legal terms for us to include this icon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Bioconductor
4 participants