Deprecated public calls with unused parameters

src/Simple.OData.Client.Core/Adapter/ResponseReaderBase.cs

@@ -56,7 +56,13 @@ public async Task AssignBatchActionResultsAsync(IODataClient client,
 
 	protected abstract void ConvertEntry(ResponseNode entryNode, object entry);
 
+	[Obsolete("The feed annotations are ignored.  Use the method StartFeed(Stack<ResponseNode> nodeStack) instead.")]
 	protected void StartFeed(Stack<ResponseNode> nodeStack, ODataFeedAnnotations feedAnnotations)
+	{
+		StartFeed(nodeStack);
+	}
+
+	protected void StartFeed(Stack<ResponseNode> nodeStack)
 	{
 		nodeStack.Push(new ResponseNode
 		{

src/Simple.OData.Client.Core/Cache/ITypeCache.cs

@@ -130,14 +130,23 @@ public interface ITypeCache
 	/// <returns></returns>
 	IEnumerable<FieldInfo> GetAllFields(Type type);
 
+	/// <summary>
+	/// Get a field for a type
+	/// </summary>
+	/// <param name="type"></param>
+	/// <param name="fieldName"></param>
+	/// <returns></returns>
+	[Obsolete("The includeNonPublic field is ignored.  Use the method GetAnyField(Type type, string fieldName) instead.")]
+	FieldInfo GetAnyField(Type type, string fieldName, bool includeNonPublic);
+
 	/// <summary>
 	/// Get a field for a type
 	/// </summary>
 	/// <param name="type"></param>
 	/// <param name="fieldName"></param>
 	/// <param name="includeNonPublic"></param>
 	/// <returns></returns>
-	FieldInfo GetAnyField(Type type, string fieldName, bool includeNonPublic = false);
+	FieldInfo GetAnyField(Type type, string fieldName);
 
 	/// <summary>
 	/// Get declared fields for a type

src/Simple.OData.Client.Core/Cache/TypeCache.cs

@@ -130,9 +130,17 @@ public IEnumerable<FieldInfo> GetAllFields(Type type)
 	}
 
 	/// <copydoc cref="ITypeCache.GetAnyField" />
-	public FieldInfo GetAnyField(Type type, string fieldName, bool includeNonPublic = false)
+
+	[Obsolete("The includeNonPublic field is ignored.  Use the method GetAnyField(Type type, string fieldName) instead.")]
+	public FieldInfo GetAnyField(Type type, string fieldName, bool includeNonPublic)
+	{
+		return GetAnyField(type, fieldName);
+	}
+
+	/// <copydoc cref="ITypeCache.GetAnyField" />
+	public FieldInfo GetAnyField(Type type, string fieldName)
 	{
-		return Resolver(type).GetAnyField(fieldName, includeNonPublic);
+		return Resolver(type).GetAnyField(fieldName);
 	}
 
 	/// <copydoc cref="ITypeCache.GetDeclaredFields" />

src/Simple.OData.Client.Core/Cache/TypeCacheResolver.cs

@@ -168,7 +168,13 @@ public PropertyInfo GetDeclaredProperty(string propertyName)
 		return TypeInfo.GetDeclaredProperty(propertyName);
 	}
 
-	public FieldInfo GetAnyField(string fieldName, bool includeNonPublic = false)
+	[Obsolete("The includeNonPublic field is ignored.  Use the method GetAnyField(string fieldName) instead.")]
+	public FieldInfo GetAnyField(string fieldName, bool includeNonPublic)
+	{
+		return GetAnyField(fieldName);
+	}
+
+	public FieldInfo GetAnyField(string fieldName)
 	{
 		var currentType = Type;
 		while (currentType != null && currentType != typeof(object))

src/Simple.OData.Client.Core/Extensions/TypeExtensions.cs

@@ -101,7 +101,13 @@ public static IEnumerable<FieldInfo> GetAllFields(this Type type)
 		return fields.ToArray();
 	}
 
-	public static FieldInfo GetAnyField(this Type type, string fieldName, bool includeNonPublic = false)
+	[Obsolete("The includeNonPublic field is ignored.  Use the method GetAnyField(Type type, string fieldName) instead.")]
+	public static FieldInfo GetAnyField(this Type type, string fieldName, bool includeNonPublic)
+	{
+		return GetAnyField(type, fieldName);
+	}
+
+	public static FieldInfo GetAnyField(this Type type, string fieldName)
 	{
 		var currentType = type;
 		while (currentType != null && currentType != typeof(object))

src/Simple.OData.Client.Core/GlobalSuppressions.cs

@@ -6,15 +6,33 @@
 using System.Diagnostics.CodeAnalysis;
 
 [assembly: SuppressMessage(
-	"Style", "IDE0060:Remove unused parameter",
+	"Style",
+	"IDE0060:Remove unused parameter",
 	Justification = "Required signature",
 	Scope = "member",
 	Target = "~M:Simple.OData.Client.ODataExpression.op_True(Simple.OData.Client.ODataExpression)~System.Boolean")
 ]
 
 [assembly: SuppressMessage(
-	"Style", "IDE0060:Remove unused parameter",
+	"Style",
+	"IDE0060:Remove unused parameter",
+	Justification = "Required signature",
+	Scope = "member",
+	Target = "~M:Simple.OData.Client.ODataExpression`1.op_True(Simple.OData.Client.ODataExpression`1)~System.Boolean")
+]
+
+[assembly: SuppressMessage(
+	"Style",
+	"IDE0060:Remove unused parameter",
 	Justification = "Required signature",
 	Scope = "member",
 	Target = "~M:Simple.OData.Client.ODataExpression.op_False(Simple.OData.Client.ODataExpression)~System.Boolean")
 ]
+
+[assembly: SuppressMessage(
+	"Style",
+	"IDE0060:Remove unused parameter",
+	Justification = "Required signature",
+	Scope = "member",
+	Target = "~M:Simple.OData.Client.ODataExpression`1.op_False(Simple.OData.Client.ODataExpression`1)~System.Boolean")
+]

src/Simple.OData.Client.Core/SimplePluralizer.cs

@@ -173,7 +173,7 @@ private class Word
 	{
 		public readonly string Singular;
 		public readonly string Plural;
-		public Word(string singular, string plural, string plural2)
+		public Word(string singular, string plural)
 		{
 			Singular = singular;
 			Plural = plural;
@@ -231,7 +231,7 @@ private static void PopulateLookupTables()
 				p = s;
 			}
 
-			var w = new Word(s, p, p2);
+			var w = new Word(s, p);
 			_specialSingulars.Add(s, w);
 			_specialPlurals.Add(p, w);
 			if (!string.IsNullOrEmpty(p2))

src/Simple.OData.Client.V3.Adapter/ResponseReader.cs

@@ -1,11 +1,11 @@
-using Microsoft.Data.Edm;
-using Microsoft.Data.OData;
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Net;
 using System.Net.Http;
 using System.Threading.Tasks;
+using Microsoft.Data.Edm;
+using Microsoft.Data.OData;
 
 namespace Simple.OData.Client.V3.Adapter
 {
@@ -174,7 +174,7 @@ private ODataResponse ReadResponse(ODataReader odataReader, IODataResponseMessag
 				switch (odataReader.State)
 				{
 					case ODataReaderState.FeedStart:
-						StartFeed(nodeStack, CreateAnnotations(odataReader.Item as ODataFeed));
+						StartFeed(nodeStack);
 						break;
 
 					case ODataReaderState.FeedEnd:

src/Simple.OData.Client.V4.Adapter/ResponseReader.cs

@@ -174,7 +174,7 @@ private ODataResponse ReadResponse(ODataReader odataReader, IODataResponseMessag
 				{
 					case ODataReaderState.ResourceSetStart:
 					case ODataReaderState.DeltaResourceSetStart:
-						StartFeed(nodeStack, CreateAnnotations(odataReader.Item as ODataResourceSetBase));
+						StartFeed(nodeStack);
 						break;
 
 					case ODataReaderState.ResourceSetEnd: