Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added guard to avoid unnecessary session initialization semaphore locks. #894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added guard to avoid unnecessary session initialization semaphore locks. #894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Simple.OData.Client.Core/Session.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ public void Dispose()
private readonly SemaphoreSlim _initializeSemaphore = new(1);
public async Task Initialize(CancellationToken cancellationToken)
{
//Avoid unnecessary locks
if (MetadataCache != null && _adapter != null)
return;

// Just allow one schema request at a time, unlikely to be much contention but avoids multiple requests for same endpoint.
await _initializeSemaphore.WaitAsync(cancellationToken).ConfigureAwait(false);

Expand Down