-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support Microsoft.OData.Core >= 8.0 #937
base: main
Are you sure you want to change the base?
Conversation
Hey there, can I help somehow with this ? |
@GerkinDev I can't speak for the maintainer, but I guess we would have to fix the examples and understand why some URLs now contain |
I've tried running it in my app directly, without success. But since the app is mid-size, it can totally be caused by something else. I'll dig deeper and try to come with some help if I can |
Hello, FYI I've managed to fully migrate my app to .net 8.0, and your fork works just fine :) |
@robertmclaws since you seem to own this repo, what is your take on this? Would it be okay if we would remove backwards compatibility and make everything run on .net 8 only? |
This PR should be merged as-is, what's the hold up? |
The examples are gone and some tests are failing. It would be good if this could be fixed. |
Hi folks. Is there a target date for the merge? Thanks! |
Wanted to add that we just now ran into this issue as well. |
I'll try to take a look at falling test cases. No promises but there's no reason I (or anyone) don't. |
@GerkinDev they are already fixed here #943 |
Hey folks, just an FYI you can't drop support for .NET 4.8 and .NET Standard 2.0 in the v6 release... the update we're getting ready to put out is a non-breaking change update. We can re-evaluate if those platforms should be supported for v7, but it's also important to note that not everyone on .NET 8 will be running OData 8.0 as it has breaking changes under the hood. There are also a lot of fixes I have put in here that have been undone, like using wildcards for package references, that would need to be put back before it would be accepted. |
This is an attempt to support Microsoft.OData.Core >= 8.0. Don't merge it, it's incomplete.
OData
and notodata
in the URI.