Index observability: otel spans, TASTy diagnostics, client error surfacing#93
Merged
Conversation
…acing Threads tracing and failure-surfacing through the index + LSP layers, and fixes a stray-state bug in the Java frontend. - ServerImpl: an `op(name)(fa)` wrapper traces every LSP op in a span and, on failure, pushes the full stacktrace to the client Output channel (window/logMessage, Error) so it's visible in the editor without the trace backend. New LoggingUtils.logError. - Indexing spans: IndexManager/TastyIndexer/SymbolIndexer take `Tracer[IO]`; bootstrap opens an `index.bootstrap` root span, each library nests under an `index.jar` span carrying symbol counts and recording exceptions. - TASTy diagnostics: TastyIndexer returns `(Indexed, List[IndexDiagnostic])` and attaches read errors/warnings to the current span. - JavaFrontendDriver: type-check against a fresh StoreReporter instead of leaking the caller's reporter state. Stacked on the compile-concurrency PR (shares ServerImpl). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Threads tracing and failure-surfacing through the index + LSP layers, plus a Java-frontend correctness fix. (Originally stacked on #92; rebased onto
mainnow that #92 is merged.)ServerImpl.op(name)(fa)wraps every LSP op in a span and, on failure, pushes the full stacktrace to the client Output channel (window/logMessage, Error) so it's visible in the editor without the trace backend. NewLoggingUtils.logError.IndexManager/TastyIndexer/SymbolIndexernow takeTracer[IO];bootstrapopens anindex.bootstraproot span and each library nests under anindex.jarspan carrying symbol counts and recording exceptions.TastyIndexerreturns(Indexed, List[IndexDiagnostic])and attaches TASTy read errors/warnings to the current span.JavaFrontendDriverfix — type-check against a freshStoreReporterrather than leaking the caller's reporter state.Test
./mill __.compileclean;./mill sls.test598/598 green.Note: under the heavier
./mill _.test(all modules in parallel) the timing-sensitiveDidSaveCompileConcurrencySpec(300ms window, from #92) can flake. Not touched by this PR — worth making that spec load-robust separately.🤖 Generated with Claude Code