Skip to content

Commit

Permalink
Fix failed signatures with multiple transitions (trusteddomainproject…
Browse files Browse the repository at this point in the history
…#172)

Commit f6b57dc causes messages transitioning multiple times in the same
Authserv-ID domain to always have an ARC result of fail. This commit
allows that to happen and takes the most recent result instead.
  • Loading branch information
abeverley committed Aug 29, 2024
1 parent eb430db commit c0db74c
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions openarc/openarc.c
Original file line number Diff line number Diff line change
Expand Up @@ -3673,14 +3673,15 @@ mlfi_eom(SMFICTX *ctx)
arfound += 1;
if (arfound > 1)
{
arc_set_cv(afc->mctx_arcmsg,
ARC_CHAIN_FAIL);

/* Assume that AR headers are being processed by
* the most recent first. If a message is transitioning
* between multiple systems in the same authserv-id then
* use the most recent one and skip the rest. */
if (conf->conf_dolog)
{
syslog(LOG_INFO,
"%s: chain state forced to \"fail\" due to multiple results present",
afc->mctx_jobid);
"%s: ignoring earlier authentication-results %s in same authserv-id",
afc->mctx_jobid, ares_getresult(ar.ares_result[n].result_result));
}

continue;
Expand Down

0 comments on commit c0db74c

Please sign in to comment.