Start testing PHP 8.4

simplesamlphp · Dec 2, 2024 · e360ca0 · e360ca0
1 parent aee5a9d
commit e360ca0
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 13 deletions.
diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml
@@ -51,7 +51,7 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           # Should be the higest supported version, so we can use the newest tools
-          php-version: '8.3'
+          php-version: '8.4'
           tools: composer, composer-require-checker, composer-unused, phpcs
           extensions: ctype, date, dom, pcre, spl, xml
 
@@ -142,7 +142,7 @@ jobs:
       fail-fast: false
       matrix:
         operating-system: [ubuntu-latest]
-        php-versions: ['8.1', '8.2', '8.3']
+        php-versions: ['8.1', '8.2', '8.3', '8.4']
 
     steps:
       - name: Setup PHP, with composer and extensions
@@ -182,15 +182,15 @@ jobs:
         run: composer install --no-progress --prefer-dist --optimize-autoloader
 
       - name: Run unit tests with coverage
-        if: ${{ matrix.php-versions == '8.3' }}
+        if: ${{ matrix.php-versions == '8.4' }}
         run: vendor/bin/phpunit
 
       - name: Run unit tests (no coverage)
-        if: ${{ matrix.php-versions != '8.3' }}
+        if: ${{ matrix.php-versions != '8.4' }}
         run: vendor/bin/phpunit --no-coverage
 
       - name: Save coverage data
-        if: ${{ matrix.php-versions == '8.3' }}
+        if: ${{ matrix.php-versions == '8.4' }}
         uses: actions/upload-artifact@v4
         with:
           name: coverage-data
@@ -204,7 +204,7 @@ jobs:
       fail-fast: true
       matrix:
         operating-system: [windows-latest]
-        php-versions: ['8.1', '8.2', '8.3']
+        php-versions: ['8.1', '8.2', '8.3', '8.4']
 
     steps:
       - name: Setup PHP, with composer and extensions

diff --git a/src/XML/cas/Attributes.php b/src/XML/cas/Attributes.php
@@ -137,7 +137,7 @@ public static function fromXML(DOMElement $xml): static
      * @param \DOMElement|null $parent The element we should append this Attributes to.
      * @return \DOMElement
      */
-    public function toXML(DOMElement $parent = null): DOMElement
+    public function toXML(?DOMElement $parent = null): DOMElement
     {
         $e = $this->instantiateParentElement($parent);
 

diff --git a/src/XML/cas/AuthenticationFailure.php b/src/XML/cas/AuthenticationFailure.php
@@ -103,7 +103,7 @@ public static function fromXML(DOMElement $xml): static
      * @param \DOMElement|null $parent The element we should append to.
      * @return \DOMElement This AuthenticatioFailure-element.
      */
-    public function toXML(DOMElement $parent = null): DOMElement
+    public function toXML(?DOMElement $parent = null): DOMElement
     {
         $e = $this->instantiateParentElement($parent);
         $e->textContent = $this->getContent();

diff --git a/src/XML/cas/AuthenticationSuccess.php b/src/XML/cas/AuthenticationSuccess.php
@@ -125,7 +125,7 @@ public static function fromXML(DOMElement $xml): static
      * @param \DOMElement|null $parent The element we should append this AuthenticationSuccess to.
      * @return \DOMElement
      */
-    public function toXML(DOMElement $parent = null): DOMElement
+    public function toXML(?DOMElement $parent = null): DOMElement
     {
         $e = $this->instantiateParentElement($parent);
 

diff --git a/src/XML/cas/Proxies.php b/src/XML/cas/Proxies.php
@@ -73,7 +73,7 @@ public static function fromXML(DOMElement $xml): static
      * @param \DOMElement|null $parent The element we should append this Proxies to.
      * @return \DOMElement
      */
-    public function toXML(DOMElement $parent = null): DOMElement
+    public function toXML(?DOMElement $parent = null): DOMElement
     {
         $e = $this->instantiateParentElement($parent);
 

diff --git a/src/XML/cas/ProxyFailure.php b/src/XML/cas/ProxyFailure.php
@@ -102,7 +102,7 @@ public static function fromXML(DOMElement $xml): static
      * @param \DOMElement|null $parent The element we should append to.
      * @return \DOMElement This ProxyFailure-element.
      */
-    public function toXML(DOMElement $parent = null): DOMElement
+    public function toXML(?DOMElement $parent = null): DOMElement
     {
         $e = $this->instantiateParentElement($parent);
         $e->textContent = $this->getContent();

diff --git a/src/XML/cas/ProxySuccess.php b/src/XML/cas/ProxySuccess.php
@@ -76,7 +76,7 @@ public static function fromXML(DOMElement $xml): static
      * @param \DOMElement|null $parent The element we should append to.
      * @return \DOMElement This ProxySuccess-element.
      */
-    public function toXML(DOMElement $parent = null): DOMElement
+    public function toXML(?DOMElement $parent = null): DOMElement
     {
         $e = $this->instantiateParentElement($parent);
 

diff --git a/src/XML/cas/ServiceResponse.php b/src/XML/cas/ServiceResponse.php
@@ -90,7 +90,7 @@ public static function fromXML(DOMElement $xml): static
      * @param \DOMElement|null $parent The element we should append this ServiceResponse to.
      * @return \DOMElement
      */
-    public function toXML(DOMElement $parent = null): DOMElement
+    public function toXML(?DOMElement $parent = null): DOMElement
     {
         $e = $this->instantiateParentElement($parent);