Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CAS error constants #4

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

dlundgren
Copy link
Contributor

While trying to deploy a simplesamlphp installation using the simplesamlphp/simplesamlphp-module-casserver@dev-master I found that these constants were missing from the SimpleSAML\CAS\Constants class.

If you'd rather these only be a part of the casserver module, I can get a PR going on that repo instead.

@tvdijen
Copy link
Member

tvdijen commented Jul 10, 2024

I'm glad someone is actually testing and using this, because I wrote the xml-cas library, but I'm actually not using CAS at all..
Given the specs I think it makes sense to add constants for all four errors.

Would you help me to get the casserver-module 'back on track'? This library is one part of it, but I also want to convert it to use Symfony routing/controllers and it's hard for me to test something I'm not using.

@tvdijen tvdijen merged commit 4061289 into simplesamlphp:master Jul 10, 2024
12 checks passed
@tvdijen
Copy link
Member

tvdijen commented Jul 10, 2024

I've tagged a new version and updated the casserver master-branch to use the new constants. Can you give it a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants