Migrate phpunit metadata to attributes

simplesamlphp · Mar 19, 2024 · 0d42fdd · 0d42fdd
1 parent de6b335
commit 0d42fdd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 22 deletions.
diff --git a/tests/CryptoEncoding/PEMBundleTest.php b/tests/CryptoEncoding/PEMBundleTest.php
@@ -5,6 +5,7 @@
 namespace SimpleSAML\XMLSecurity\Test\CryptoEncoding;
 
 use LogicException;
+use PHPUnit\Framework\Attributes\Depends;
 use PHPUnit\Framework\TestCase;
 use SimpleSAML\XMLSecurity\CryptoEncoding\PEM;
 use SimpleSAML\XMLSecurity\CryptoEncoding\PEMBundle;
@@ -43,21 +44,19 @@ public function testBundle(): PEMBundle
 
 
     /**
-     * @depends testBundle
-     *
      * @param \SimpleSAML\XMLSecurity\CryptoEncoding\PEMBundle $bundle
      */
+    #[Depends('testBundle')]
     public function testAll(PEMBundle $bundle): void
     {
         $this->assertContainsOnlyInstancesOf(PEM::class, $bundle->all());
     }
 
 
     /**
-     * @depends testBundle
-     *
      * @param \SimpleSAML\XMLSecurity\CryptoEncoding\PEMBundle $bundle
      */
+    #[Depends('testBundle')]
     public function testFirst(PEMBundle $bundle): void
     {
         $this->assertInstanceOf(PEM::class, $bundle->first());
@@ -66,10 +65,9 @@ public function testFirst(PEMBundle $bundle): void
 
 
     /**
-     * @depends testBundle
-     *
      * @param \SimpleSAML\XMLSecurity\CryptoEncoding\PEMBundle $bundle
      */
+    #[Depends('testBundle')]
     public function testLast(PEMBundle $bundle): void
     {
         $this->assertInstanceOf(PEM::class, $bundle->last());
@@ -78,21 +76,19 @@ public function testLast(PEMBundle $bundle): void
 
 
     /**
-     * @depends testBundle
-     *
      * @param \SimpleSAML\XMLSecurity\CryptoEncoding\PEMBundle $bundle
      */
+    #[Depends('testBundle')]
     public function testCount(PEMBundle $bundle): void
     {
         $this->assertCount(150, $bundle);
     }
 
 
     /**
-     * @depends testBundle
-     *
      * @param \SimpleSAML\XMLSecurity\CryptoEncoding\PEMBundle $bundle
      */
+    #[Depends('testBundle')]
     public function testIterator(PEMBundle $bundle): void
     {
         $values = [];
@@ -104,21 +100,19 @@ public function testIterator(PEMBundle $bundle): void
 
 
     /**
-     * @depends testBundle
-     *
      * @param \SimpleSAML\XMLSecurity\CryptoEncoding\PEMBundle $bundle
      */
+    #[Depends('testBundle')]
     public function testString(PEMBundle $bundle): void
     {
         $this->assertIsString($bundle->string());
     }
 
 
     /**
-     * @depends testBundle
-     *
      * @param \SimpleSAML\XMLSecurity\CryptoEncoding\PEMBundle $bundle
      */
+    #[Depends('testBundle')]
     public function testToString(PEMBundle $bundle): void
     {
         $this->assertIsString(strval($bundle));
@@ -168,10 +162,9 @@ public function testLastEmptyFail(): void
 
 
     /**
-     * @depends testBundle
-     *
      * @param \SimpleSAML\XMLSecurity\CryptoEncoding\PEMBundle $bundle
      */
+    #[Depends('testBundle')]
     public function testWithPEMs(PEMBundle $bundle): void
     {
         $bundle = $bundle->withPEMs(new PEM('TEST', 'data'));

diff --git a/tests/CryptoEncoding/PEMTest.php b/tests/CryptoEncoding/PEMTest.php
@@ -4,6 +4,7 @@
 
 namespace SimpleSAML\XMLSecurity\Test\CryptoEncoding;
 
+use PHPUnit\Framework\Attributes\Depends;
 use PHPUnit\Framework\TestCase;
 use RuntimeException;
 use SimpleSAML\XMLSecurity\CryptoEncoding\PEM;
@@ -51,10 +52,9 @@ public function testFromFile(): PEM
 
 
     /**
-     * @depends testFromFile
-     *
      * @param \SimpleSAML\XMLSecurity\CryptoEncoding\PEM $pem
      */
+    #[Depends('testFromFile')]
     public function testType(PEM $pem): void
     {
         $this->assertEquals(PEM::TYPE_PUBLIC_KEY, $pem->type());
@@ -101,21 +101,19 @@ public function testInvalidFile(): void
 
 
     /**
-     * @depends testFromFile
-     *
      * @param \SimpleSAML\XMLSecurity\CryptoEncoding\PEM $pem
      */
+    #[Depends('testFromFile')]
     public function testString(PEM $pem): void
     {
         $this->assertIsString($pem->string());
     }
 
 
     /**
-     * @depends testFromFile
-     *
      * @param \SimpleSAML\XMLSecurity\CryptoEncoding\PEM $pem
      */
+    #[Depends('testFromFile')]
     public function testToString(PEM $pem): void
     {
         $this->assertIsString(strval($pem));