Disable formatting on signed elements

simplesamlphp · Jul 30, 2024 · ff6f14f · ff6f14f
1 parent cb73e44
commit ff6f14f
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/XML/SignedElementTrait.php b/src/XML/SignedElementTrait.php
@@ -74,6 +74,11 @@ public function getSignature(): ?Signature
      */
     protected function setSignature(Signature $signature): void
     {
+        /**
+         * By disabling formatting on signed objects, we prevent issues with invalid signatures later on
+         * at the cost of some whitespace taking up useless bytes in the outputted document.
+         */
+        $this->formatOutput = false;
         $this->signature = $signature;
     }