[webpush] Parsing during registration #1661
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the parsing of web push device tokens: the keys and endpoint are parsed during registration, which avoid late failure.
It also adds tests for the decoding, and the encryption, using the RFC8291 example.
There are still some
todoin the comments, but I prefer to see the different points before removing them:I haven't changed how the push notification is encoded for webpush (the todo suggests to move to ToJSON). I had the implementation, but I preferred to discuss it first. The reasons are:
apnsPushProviderClientandwpPushProviderClientdo not restrict during compile time to a defined PushProvider type and fails with PPInvalidPusher if it is used with the wrong provider. It's because these functions are used in a single place which is easily controlled that we don't mix the different pushers. Doing the restriction during compilation would require introducing some GADTS which would add a lot of complexity to the code for an arguable benefit