Skip to content

Conversation

@arneboockmeyer
Copy link
Member

@lpirl please review #61 first

@arneboockmeyer arneboockmeyer requested a review from lpirl June 21, 2024 12:20
Copy link
Contributor

@lpirl lpirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment that needs attention (mysteriously deleted code)

Comment on lines 25 to 30
p1 = np.array((node_before.lat, node_before.lon))
p2 = np.array((node_after.lat, node_after.lon))
p3 = np.array((signal.lat, signal.lon))
return np.abs(np.cross(p2 - p1, p1 - p3)) / Decimal(
haversine((node_before.lat, node_before.lon), (node_after.lat, node_after.lon))
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand why this code went way.

Copy link
Contributor

@lpirl lpirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx

@arneboockmeyer arneboockmeyer merged commit d166004 into main Feb 14, 2025
2 checks passed
@arneboockmeyer arneboockmeyer deleted the lint branch February 14, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants