[monk] SEF Rework #9386
Open
[monk] SEF Rework #9386
+387
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Freeze buff expiration while SEF actions are occurring. * Finish crit double dipping. * Correctly call the base action method to bypass parsing. * Add SEF actions as children to the parent action. * Hook up Blackout Kick. * Create SEF BETA monk option to use new SEF. * Remove Chi Burst healing targets monk option.
renanthera
force-pushed
the
sef-rework
branch
from
198b237
to
ef32527
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor SEF to more automatically implement SEF scaling bugs and allow for usage of
parse_effectsmore easily.parse_effectsoverrides.