[Death Knight] Convert Blood APL from Mandl's pin #9613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the APLs pinned in Acherus to a single file with a sub APL for each hero talent tree. Each APL is verified to work against a dev profile.
I debated combining them into a single APL to remove some duplicate lines, but splitting it out by hero talent was more readable due to the relatively short APL. San'layn inserts enough rotational differences that it felt awkward to read if you just wanted to see what Deathbringer is doing. A maintainer needs to either dissect the APL for the hero talent they're using, or they need to update generic conditions in two places. There is a maintainability cost either way.