Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary Dark Mode CSS #2155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove unnecessary Dark Mode CSS #2155

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15c72ef
Remove unnecessary dark mode CSS
mquevill Mar 21, 2024
0b9025a
Remove temporary fix
mquevill Mar 21, 2024
8e1359c
Merge branch 'main' into RemoveUnnecessaryCSS
mquevill Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions css/dark-mode.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,50 +163,11 @@ html.dark-mode ._9xq0 {
color: var(--primary-text);
}

/* Removing top gap */
/* TODO: Remove when fixed by fb */
.__fb-dark-mode {
--header-height: 0 !important;
}
Comment on lines -168 to -170
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the newest round of Facebook's redesign, this actually needs to be removed, otherwise the bottom of the page is partially off the screen (See the button on the bottom left being cut off below)
image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I literally just reported the cut off thing as an issue for dark mode, nice to see the code update to fix it is already ready already!


/* Message list: fix for received messages text color in dark mode */
/* TODO: Remove when fixed by fb */
.__fb-dark-mode .__fb-light-mode {
--primary-text: #e4e6eb;
}

/* Radio buttons */
.x14yjl9h.xudhj91.x18nykt9.xww2gxu.x13fuv20.xu3j5b3.x1q0q8m5.x26u7qi.xamhcws.xol2nv.xlxy82.x19p7ews.x9f619.x1rg5ohu.x2lah0s.x1n2onr6.x1tz4bnf.xmds5ef.x25epmt.x11y6y4w.xxk0z11.xvy4d1p {
--accent: var(--primary-text);
}

/* Backgrounds of various buttons ("Join room", "Visit Group", Audio call, etc.) */
/* TODO: Remove when fixed by fb, since -floating should not be here */
html.dark-mode .x14yjl9h.xudhj91.x18nykt9.xww2gxu.x6s0dn4.x972fbf.xcfux6l.x1qhh985.xm0m39n.x9f619.x3nfvp2.xl56j7k.x1n2onr6.x1qhmfi1.xc9qbxq.x14qfxbe,
html.dark-mode .x1n2onr6.x1ja2u2z.x78zum5.x2lah0s.xl56j7k.x6s0dn4.xozqiw3.x1q0g3np.xi112ho.x17zwfj4.x585lrc.x1403ito.x972fbf.xcfux6l.x1qhh985.xm0m39n.x9f619.xn6708d.x1ye3gou.x1qhmfi1.x1r1pt67 {
background-color: var(--secondary-button-background-floating) !important;
}

/* Search results: Close button */
/* TODO: Remove when fixed by fb, since --always-white is not good here */
html.dark-mode .x14hiurz.x1r1pt67 {
background-color: var(--secondary-button-background) !important;
}

/* Attachment background color in Chat Box */
/* TODO: Remove when fixed by fb, since #d6d9dd is too bright here */
/* Current Background-Color is same style as add attachment button */
html.dark-mode .x1ybostu {
background-color: rgba(134 142 153 / 25%);
}

/* Recipient Pills in new message form */
/* TODO: Remove when fixed by fb, since #f3f3f4 is too bright here */
/* It seems FB uses shades of blue here */
html.dark-mode .x4noic3 {
background-color: var(--secondary-button-background);
}

/* Create room icon color */
html.dark-mode .x1p6odiv {
color: var(--primary-icon);
Expand Down