SetRequired: Fix support for removal of optional modifiers from tuples
#1030
+238
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-sm
force-pushed
the
fix/set-required-type-with-tuples
branch
from
07f7ec6 to
d97191d
Compare
sindresorhus
approved these changes
Jan 3, 2025
|
Can you add |
sindresorhus
changed the title
SetRequired: Fix enabling removal of optional modifiers from tuplesSetRequired: Fix support for removal of optional modifiers from tuples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes
SetRequired, enabling it to remove optional modifiers from tuples, for eg.,This fix will allow us to solve
SetRequiredDeepdoesn't remove optional modifiers from tuples #1026.Fixes minor issues with
IsArrayReadonlyand adds tests for it.Adds an internal
IfArrayReadonlytype.