Fix duplicated rows #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Querying with 'gte' will lead to duplicated rows if the last oplog entry is for a collection that is supposed to be replicated. Because of the change done in efd5e0f this will not happen for every sync as it's quite likely that the last oplog entry references a modification in a different collection.
|
Hi @Tolsto, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Query oplog with 'gt' instead of 'gte'.
Querying with 'gte' will lead to duplicated rows if the last
oplog entry is for a collection that is supposed to be replicated.
Because of the change done in efd5e0f
this will not happen for every sync as it's quite likely that the last
oplog entry references a modification in a different collection.
QA steps
Risks
Rollback steps