Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redirects stream #80

Closed
wants to merge 1 commit into from

Conversation

jgdwyer
Copy link

@jgdwyer jgdwyer commented Jan 21, 2021

Description of change

Adds a new redirects Stream to sync Shopify Online-Store/Redirect data.

Because there are no timestamp properties on the Redirect data, I had to configure it as a full table replication and override the base get_objects function. I used the collects module as a template for this.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    • Running the steps in the makefile individually works (for some reason I was getting an error when running make test)
    • Also got expected redirect data from an existing Shopify store, including when pagination was required.

Risks

  • This is my first development work on a tap, so it's possible I messed something up :-)

Rollback steps

  • revert this branch

@cmerrick
Copy link

Hi @jgdwyer, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link

You did it @jgdwyer!

Thank you for signing the Singer Contribution License Agreement.

@jgdwyer
Copy link
Author

jgdwyer commented Jul 15, 2021

closing since now duplicated by #113

@jgdwyer jgdwyer closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants