Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use next_page_token to fix zoom tap pagination #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GJmelody
Copy link

Description of change

page_number is a deprecated API param and is not being used now. Zoom doesn't take this param so it always only gets the results from the first page. To fix this issue we should use next_page_token instead based on Zoom document
image

Manual QA steps

  • Tested with my own zoom account and credentials

Risks

  • N/A

Rollback steps

  • revert this branch

lfpll pushed a commit to lfpll/tap-zoom that referenced this pull request Dec 13, 2022
* Set csat_score type to string

* Use utility function to start the merging job for maestroqa

* Switch target BQ dataset to masterdata_maestroqa
@rdeshmukh15
Copy link
Contributor

rdeshmukh15 commented Mar 30, 2023

It is observed that on Zoom API doc for below API endpoints :

  1. 'meetings/{meeting_id}/registrants'
  2. '/webinars/{webinarId}/registrants'

It is mentioned that page_number will be deprecated in next release and start using next_page_token.
Screenshot 2023-03-30 at 11 53 15 PM

But as the per the postman response, we don't get the next_page_token in the response. Hence, this change cannot be made at the moment.
Attaching the part of postman response here :

PR-13-analysis

For list_meetings (/users/{userId}/meetings), it is observed that next_page_token is mentioned in the API doc but in actual response, it is not appearing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants