Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The version is currently hard-coded as 0.1.0-dev:
TileDB-SOMA-ML/src/tiledbsoma_ml/__init__.py
Line 12 in e985fcb
Thus even though there are tags available, they are ignored:
And because of this hard-coding, I can't override the version string in the conda recipe using
SETUPTOOLS_SCM_PRETEND_VERSION
(TileDB-Inc/tiledb-soma-ml-feedstock#5 (comment)).Solution
I decided to use the latest setuptools-scm 8+ solution, so I deleted the section
tool.setuptools.dynamic
, which uses the dynamic metadata feature of setuptools.I managed to get it working. I also confirmed that
SETUPTOOLS_SCM_PRETEND_VERSION
mostly works now.There is still some strangeness. First, our
alpha
gets truncated toa
. I think this is because of PEP 440. Also, it reports0.1.0a3
(as above in the output frompython -m setuptools_scm
), which I don't understand. Hopefully once we drop thealpha
from our version strings the dynamic versions will be more predictable.