Fix circular imports between helpers and validation #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Upstream repos using OGE were failing pytest due to circular imports in OGE between the
helpers
andvalidation
module. This PR restructures the repo to avoid these circular imports, mostly by removing any calls tovalidation
from thehelpers
moduleWhat the code is doing
identify_percent_of_data_by_input_source
fromvalidation
tooutput_data
test_for_missing_subplant_id
from validation to helpers since it is only used by a single function in helpers.Testing
No testing yet. Not sure if there is an easy way to check whether any additional circular imports exist.
Review estimate
10 minutes
Future work
Implement test for circular imports?
Checklist
ruff