Skip to content

Commit

Permalink
minor changes
Browse files Browse the repository at this point in the history
  • Loading branch information
sinhaharsh committed Nov 22, 2023
1 parent 089d807 commit 6a7f153
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions protocol/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from abc import ABC, abstractmethod
from collections.abc import MutableMapping
from numbers import Number
from pathlib import Path
from typing import Iterable, Union

import numpy as np
Expand Down Expand Up @@ -602,7 +603,7 @@ class BaseSequence(MutableMapping):
Name of the sequence.
params : set
A set of parameters in the sequence.
path : str
path : Path | str
Path to the sequence on disk.
Examples
Expand Down Expand Up @@ -631,7 +632,7 @@ class BaseSequence(MutableMapping):
def __init__(self,
name: str = 'Sequence',
params: set = None,
path: str = None, ):
path: Union[str, Path] = None, ):
"""constructor"""

super().__init__()
Expand Down
2 changes: 1 addition & 1 deletion protocol/imaging.py
Original file line number Diff line number Diff line change
Expand Up @@ -2009,7 +2009,7 @@ def _parse_private(self, dicom):
except (TypeError, ValueError):
self[name] = param_cls(Invalid)
else:
logger.warn('No private header found in DICOM file')
logger.info('No private header found in DICOM file')
# TODO: throw a warning when expected header doesnt exist
# TODO: warn if specific parameter couldn't be read or queryable etc

Expand Down
2 changes: 1 addition & 1 deletion protocol/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def header_exists(dicom: pydicom.FileDataset) -> bool:
series_header['tags']['MrPhoenixProtocol']['items'][0].split('\n')
return True
except Exception as e:
logger.warn(f'Expects dicom files from Siemens to be able to'
logger.info(f'Expects dicom files from Siemens to be able to'
f' read the private header. For other vendors,'
f'private header is skipped. '
f'{e} in {dicom.filename}')
Expand Down

0 comments on commit 6a7f153

Please sign in to comment.