-
Notifications
You must be signed in to change notification settings - Fork 4
feat: setup vitest browser mode #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v1
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for side-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
froggy1014
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코멘트 한번만 확인해주세요 ~ !
| vitest: ^2.1.8 | ||
| vite: ^6.3.5 | ||
| vitest: ^3.1.3 | ||
| vitest-browser-react: ^0.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
별거 아니긴한데, vitest-browser-react 패키지 한번 보니까, 0.2.0 버전까지 배포됬는데 호환때문에 0.1.1로 설정 해놓으신건가요 ~ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
버전업도 따로 챙겨볼게~
| browser: { | ||
| enabled: true, | ||
| headless: true, | ||
| provider: 'playwright', | ||
| instances: [{ browser: 'chromium' }], | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viteest 3 버전부터는 vitest.workspace..ts가 deprecated되서, vite.config.ts에 projects 넣어주시면 될 것 같아요.
https://vitest.dev/guide/projects
| browser: { | |
| enabled: true, | |
| headless: true, | |
| provider: 'playwright', | |
| instances: [{ browser: 'chromium' }], | |
| }, | |
| browser: { | |
| enabled: true, | |
| headless: true, | |
| provider: 'playwright', | |
| instances: [{ browser: 'chromium' }], | |
| }, | |
| projects: ['packages/*'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이것도 실제로 패키지에 적용할 때 챙겨볼게 ㅎㅎ browser mode를 쓸 때 projects에 선언하는거랑 vitest.workspace.ts 파일에 선언하는거랑 동작이 살짝 달랐던걸로 기억해서.. 😭
1d0cca5 to
ab27ab1
Compare
Changes
Visuals
Checklist
Additional Discussion Points