fix(launcher): resolve gateway startup issue in tui mode#1720
Open
darrenzeng2025 wants to merge 1 commit intosipeed:mainfrom
Open
fix(launcher): resolve gateway startup issue in tui mode#1720darrenzeng2025 wants to merge 1 commit intosipeed:mainfrom
darrenzeng2025 wants to merge 1 commit intosipeed:mainfrom
Conversation
The picoclaw-launcher-tui was not respecting PICOCLAW_HOME and PICOCLAW_CONFIG environment variables when determining the config file path. This caused a configuration mismatch between the TUI and the gateway command when these environment variables were set. Changes: - Updated ConfigPath() to check PICOCLAW_CONFIG environment variable first - Updated ConfigDir() to check PICOCLAW_HOME environment variable first - Added comprehensive unit tests for both functions - Added documentation comments explaining the priority order This ensures that launcher-tui and gateway command use the same config file path resolution logic, fixing the issue where gateway could not start from TUI. Fixes sipeed#1704
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1704
Problem
The picoclaw-launcher-tui was not respecting
PICOCLAW_HOMEandPICOCLAW_CONFIGenvironment variables when determining the config file path. This caused a configuration mismatch between the TUI and the gateway command when these environment variables were set.Root Cause
~/.picoclaw/config.jsonpathPICOCLAW_HOMEandPICOCLAW_CONFIGenvironment variablesSolution
ConfigPath()to checkPICOCLAW_CONFIGenvironment variable firstConfigDir()to checkPICOCLAW_HOMEenvironment variable firstPriority Order (consistent with gateway command)
PICOCLAW_CONFIG- direct config file pathPICOCLAW_HOME- custom config directory~/.picoclaw/config.jsonTesting
Files Changed
cmd/picoclaw-launcher-tui/internal/config/store.go- Fixed config path resolutioncmd/picoclaw-launcher-tui/internal/config/store_test.go- Added unit tests