extractaudio: Add support for DLT_RAW pcap format. #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason it fails calls2 test checksum on travis: OK: call2_ulaw -> call2_ulaw.mono.alaw.wav |
|
Jonathan,
Hmm, I don't think so. This only affects makeann, not extractaudio. Maybe
those checksums are calculated used output of the new silence compensation
code, that has not been merged into the master branch yet? I still need to
look at the differences in decoding output in detail.
…-Max
On Sat, Apr 1, 2017 at 10:59 AM, Jonathan de Boyne Pollard < ***@***.***> wrote:
I suspect that 88ab19e
<88ab19e>
is having an effect here.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#58 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AANWJi_Z-z6EMC7Yj2s1cBdkHO_UQbc-ks5rrpCMgaJpZM4MbSuI>
.
|
sobomax
force-pushed
the
master
branch
6 times, most recently
from
55700ad to
2131bec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local tools here write saved RTP files in DLT_RAW pcap format, rather than in DLT_EN10MB format. This enables extractaudio to read that format. No IPv6 support yet, though; just IPv4.
(This replaces pull request #56, which was attached to the wrong branch of my repository.)