Merge pull request #31 from axklim/allow_0_value_in_headers

Fixed bug with '0' value in the header
sirn-se · Jan 8, 2024 · 82a0166 · 82a0166
2 parents 986ae50 + 9fd9de0
commit 82a0166
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 1 deletion.
diff --git a/src/Http/Message.php b/src/Http/Message.php
@@ -172,7 +172,8 @@ private function handleHeader(string $name, string|array $value): void
         }
         $value = is_array($value) ? $value : [$value];
         foreach ($value as $content) {
-            if (!(is_string($content) || is_numeric($content)) || empty($content = trim($content))) {
+            $content = trim($content);
+            if ('' === $content) {
                 throw new InvalidArgumentException("Invalid header value(s) provided.");
             }
             $this->headers[strtolower($name)][$name][] = $content;

diff --git a/tests/suites/http/RequestTest.php b/tests/suites/http/RequestTest.php
@@ -232,4 +232,40 @@ public function testHaederValueError(): void
         $this->expectExceptionMessage("Invalid header value(s) provided.");
         $request->withHeader('name', '');
     }
+
+    /**
+     * @dataProvider provideInvalidHeaderValues
+     * @
+     */
+    public function testHeaderValueInvalidVariants($value): void
+    {
+        $request = new Request();
+        $this->expectException(InvalidArgumentException::class);
+        $request->withHeader('name', $value);
+    }
+
+    public static function provideInvalidHeaderValues(): \Generator
+    {
+        yield [''];
+        yield ['  '];
+    }
+
+    /**
+     * @dataProvider provideValidHeaderValues
+     * @
+     */
+    public function testHeaderValueValidVariants($value): void
+    {
+        $request = new Request();
+        $request = $request->withHeader('name', $value);
+        $this->assertInstanceOf(Request::class, $request);
+    }
+
+    public static function provideValidHeaderValues(): \Generator
+    {
+        yield ['null'];
+        yield ['0'];
+        yield ['  0'];
+        yield ['1'];
+    }
 }