Skip to content

Log session_id on engine session close #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leifj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Log session_id on engine session close #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/engine/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,14 @@ func (m *Manager) unregisterSession(session *Session) {
_ = m.sessionStore.Delete(context.Background(), session.ID)
}

session.logger.Info("Session closed")
// "session" (session.logger's bound field) is the user's short ID, not
// this session's own - deliberately shared across every reconnect for
// that user so log lines from the same user grep together. Without an
// explicit session_id here (unlike "Session established", which already
// logs one), two rapid reconnects for one user produce two "Session
// closed" lines that are indistinguishable from each other, which read
// as a session-eviction bug when reconnects were simply frequent.
session.logger.Info("Session closed", zap.String("session_id", session.ID))
}

// validateToken authenticates tokenString and returns its identity.
Expand Down
Loading