Close popup window after bookmark saved (#13) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Automatically close the "add bookmark" popup window after a successful save - Slight delay to display the "saved" message - Does not close window if there was an error whilst attempting to save
|
Hey! I just opened #46 which adds support for a post-save state (and allows you to update the bookmark you just added, like Chrome does). |
|
I just built your code and tested it out: looks great! Should I close my pull request? I assume your changes make this unnecessary. |
That's up to you, but yeah the change in behaviour means auto-closing is no longer required. |
|
See #46: the changes in that PR remove the need for this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #13: