-
Notifications
You must be signed in to change notification settings - Fork 838
fix: add postinstall script to fix node-pty spawn-helper permissions on macOS #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amacsmith
wants to merge
5
commits into
siteboon:main
Choose a base branch
from
amacsmith:fix/node-pty-spawn-helper-permissions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,620
−1,429
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
05dee7e
fix: add postinstall script to fix node-pty spawn-helper permissions …
1b90ff2
fix: address review feedback
e388764
Merge branch 'main' into fix/node-pty-spawn-helper-permissions
amacsmith b67bc03
Update README.md
amacsmith 34cf343
Merge branch 'main' into fix/node-pty-spawn-helper-permissions
viper151 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The troubleshooting section describes the issue as "commonly happens on macOS when installing via npx or pnpm" but the postinstall script will run for all package managers (npm, yarn, pnpm, etc.) on all platforms. Consider clarifying in the documentation that while the issue commonly occurs with certain package managers on macOS, the postinstall fix applies universally. Alternatively, if the issue is truly specific to certain installation methods, the documentation should explain why the postinstall script may not always be sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback