BUGFIX: Handle altered handling of setWidth and setHeight during scal…

…ing properly
sitegeist · Sep 6, 2018 · 49e1fc1 · 49e1fc1
1 parent ac47d62
commit 49e1fc1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/Classes/EelHelpers/AbstractImageSourceHelper.php b/Classes/EelHelpers/AbstractImageSourceHelper.php
@@ -97,6 +97,7 @@ public function srcset($mediaDescriptors): string
                     $srcsetArray[] = $scaled->src() . ' ' . $factor . 'x';
                 }
             }
+            \Neos\Flow\var_dump([$descriptors,$srcsetArray]);
             return implode(', ', $srcsetArray);
         } else {
             return $this->src();

diff --git a/Classes/EelHelpers/AssetImageSourceHelper.php b/Classes/EelHelpers/AssetImageSourceHelper.php
@@ -69,15 +69,15 @@ public function scale(float $factor): ImageSourceHelperInterface
         $scaledHelper = clone($this);
 
         if ($this->targetWidth) {
-            $scaledHelper->setWidth(round($factor * $this->targetWidth));
+            $scaledHelper = $scaledHelper->setWidth(round($factor * $this->targetWidth));
         } else {
-            $scaledHelper->setWidth(round($factor * $this->asset->getWidth()));
+            $scaledHelper = $scaledHelper->setWidth(round($factor * $this->asset->getWidth()));
         }
 
         if ($this->targetHeight) {
-            $scaledHelper->setHeight(round($factor * $this->targetHeight));
+            $scaledHelper = $scaledHelper->setHeight(round($factor * $this->targetHeight));
         } else if (!$this->targetWidth) {
-            $scaledHelper->setHeight(round($factor * $this->asset->getHeight()));
+            $scaledHelper = $scaledHelper->setHeight(round($factor * $this->asset->getHeight()));
         }
 
         return $scaledHelper;

diff --git a/Classes/EelHelpers/DummyImageSourceHelper.php b/Classes/EelHelpers/DummyImageSourceHelper.php
@@ -72,10 +72,10 @@ public function scale(float $factor): ImageSourceHelperInterface
         $scaledHelper->setBaseHeight(round($factor * $this->baseHeight));
 
         if ($this->targetWidth) {
-            $scaledHelper->setWidth(round($factor * $this->targetWidth));
+            $scaledHelper = $scaledHelper->setWidth(round($factor * $this->targetWidth));
         }
         if ($this->targetHeight) {
-            $scaledHelper->setHeight(round($factor * $this->targetHeight));
+            $scaledHelper = $scaledHelper->setHeight(round($factor * $this->targetHeight));
         }
 
         return $scaledHelper;