TASK: Optimize AssetImageSource

- disallow upscalig - calculate height with fallback to asset height when scaling if no target width is set
sitegeist · Jul 13, 2018 · 7cf7f44 · 7cf7f44
1 parent 38fc106
commit 7cf7f44
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/Classes/EelHelpers/AssetImageSourceHelper.php b/Classes/EelHelpers/AssetImageSourceHelper.php
@@ -75,6 +75,8 @@ public function scale(float $factor): ImageSourceHelperInterface
 
         if ($this->targetHeight) {
             $scaledHelper->setHeight(round($factor * $this->targetHeight));
+        } else if (!$this->targetWidth) {
+            $scaledHelper->setHeight(round($factor * $this->asset->getHeight()));
         }
 
         return $scaledHelper;
@@ -84,7 +86,7 @@ public function src(): string
     {
         $async = $this->request ? $this->async : false;
         $allowCropping = ($this->targetWidth && $this->targetHeight);
-        $allowUpScaling = true;
+        $allowUpScaling = false;
 
         $thumbnailConfiguration = new ThumbnailConfiguration(
             $this->targetWidth,