Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Runtime cache for src method of AssetImageSource #59

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

kitsunet
Copy link
Contributor

@kitsunet kitsunet commented May 18, 2022

This will make multiple calls/uses in fusion a noop after the first
use, preventing unnecessary database queries.

Fixes: #57

This will make multiple calls/uses in fusion a noop after the first
use, preventing unnecessary database queries.
@kitsunet
Copy link
Contributor Author

Really style CI 😆

Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scale and some with* methods in the AbstractScalableImageSource use clone $this internally. Without adjustment this change would copy the srcCache.

@kitsunet
Copy link
Contributor Author

kitsunet commented Nov 3, 2023

@mficzel hab das mal upgedated :D

@mficzel mficzel merged commit e0ed8f4 into sitegeist:main Nov 3, 2023
5 checks passed
@kitsunet kitsunet deleted the feature/runtime-cache-src branch November 7, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime Cache for src()
2 participants