Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Omit srcset and sizes if imageSource is non-scalable #62

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

manuelmeister
Copy link
Contributor

@manuelmeister manuelmeister commented Aug 29, 2023

Since size attribues for non scalable sources like svg files are pointless they should be avoided.
This change ensures that only scalable imageSources will render size and srcset.

@manuelmeister manuelmeister force-pushed the feature/non-scalable branch 2 times, most recently from 8b3eb12 to adc8066 Compare August 29, 2023 13:26
Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense. It would be great to only have the changes in Image.fusion and Source.fusion ... i will take care of any linter issues.

@mficzel
Copy link
Member

mficzel commented Aug 29, 2023

Will adjust myself during rebase

@mficzel mficzel merged commit cb267d9 into sitegeist:master Aug 29, 2023
7 checks passed
@manuelmeister
Copy link
Contributor Author

Thanks! Why did you revert adc8066#diff-0eb29729c0c4c6990f6489cbff5970dd109c7362d6813d70e95cdbb002031dabR233 the return null? I think it is wrong to return the src in the srcset function.

@manuelmeister manuelmeister deleted the feature/non-scalable branch August 29, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants