FEATURE: Add dataSrc method to image source interface #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mficzel
force-pushed
the
feature/dataSrc
branch
8 times, most recently
from
58e9f4d
to
39106ff
Compare
This allows to render images with a data src to avoid a separate request. The dataSrc is generated synchronously which may cause performance issues. To achieve this the generation of dummy images was extracted into the DummyImageGenerator for beeing able to crate synchonous dummy images. Also the test matrix was adjusted to include recent and upcoming php and Neos versions and removes support of outdated Neos versions.
mficzel
force-pushed
the
feature/dataSrc
branch
from
39106ff
to
df39bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to render images with a data src to avoid a separate request. The dataSrc is generated synchronously which may cause performance issues.
To achieve this the generation of dummy images was extracted into the DummyImageGenerator for beeing able to crate synchonous dummy images.
Also the test matrix was adjusted to include recent and upcoming php and Neos versions
and removes support of outdated Neos versions.