Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Add preserveAspect property #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FEATURE: Add preserveAspect property #77

wants to merge 1 commit into from

Conversation

manuelmeister
Copy link
Contributor

I think it should modify the source image based on the given dimensions and also respect the aspect ratio.

This was referenced Jun 20, 2024
Open
Open
Open
@mficzel
Copy link
Member

mficzel commented Jul 1, 2024

I like that this uses withDimensions and not withWidth + withHeight in case 2 dimensions are given. However i would like to avoid the preserveAspect flag and use the following rules:

  • if you specify both dimensions you obviously want to enforce an aspect so this is done
  • if you specify one dimension the aspect is preserved as only one dimension is important to the integration

PS: There is #73 that also uses withDimensions (and adjusts the nestedComponent in favor of @Private for performance). Would that solve this aswell?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manuelmeister @mficzel