FF7Materia: Cleanup for qml #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF7Materia Changes
Removed Cpp file
Added properties and members for convenence when using QML
Data methods are const
FF7Materia::MateriaNames => FF7Materia::MateriaNames
FF7Materia::MateriaNames::MaxMateriaAp Replaced with public varible of the same name and "maxMateriaAp" property.
qml only expose whats used
The Following methods are deprecated:
totalMateria -> TotalMateria or totalMateria (Property)
status -> addedEffects
statSTR -> strengthChange
statVIT -> vitalityChange
statMAG -> magicChange
statSPI -> spiritChange
statDEX -> dexterityChange
statLCK -> luckChange
statHP -> hpChange
statMP -> mpChange