Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump org.apache.maven.plugins:maven-pmd-plugin from 3.23.0 to 3.24.0 #205

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Bump org.apache.maven.plugins:maven-pmd-plugin from 3.23.0 to 3.24.0 #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c03c36
Bump org.apache.maven.plugins:maven-pmd-plugin from 3.23.0 to 3.24.0
dependabot[bot] Jul 19, 2024
0579d8a
pmd 7.3.0 fixes
haroon-sheikh Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
<slf4j.version>2.0.13</slf4j.version>
<maven-checkstyle-plugin.version>3.4.0</maven-checkstyle-plugin.version>
<maven-dependency-plugin.version>3.7.1</maven-dependency-plugin.version>
<maven-pmd-plugin.version>3.23.0</maven-pmd-plugin.version>
<maven-pmd-plugin.version>3.24.0</maven-pmd-plugin.version>
<system-rules.version>1.19.0</system-rules.version>
<openkeepass.version>0.8.2</openkeepass.version>
<vault-java-driver.version>6.2.0</vault-java-driver.version>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/github/sitture/envconfig/KeepassConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public Configuration getConfiguration(final String env) {
private File getKeepassDatabaseFile(final String fileName) {
final ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
final URL resource = classLoader.getResource(fileName);
File keepassFile;
File keepassFile; // NOPMD
if (null == resource) {
throw new EnvConfigException(String.format("Database %s does not exist!", fileName));
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/github/sitture/envconfig/EnvConfigPropertiesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ void testThrowsExceptionWhenKeepassMasterKeyNotPresent() {
final EnvConfigProperties configProperties = new EnvConfigProperties();
final EnvConfigException exception = Assertions.assertThrows(EnvConfigException.class,
configProperties::getKeepassProperties);
Assertions.assertEquals(String.format("Missing required variable '%s'", EnvConfigUtils.CONFIG_KEEPASS_MASTERKEY_KEY),
Assertions.assertEquals(String.format("Missing required variable '%s'", "env.config.keepass.masterkey"),
exception.getMessage());
}

Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/github/sitture/envconfig/EnvConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,8 @@ void testExceptionWhenKeepassMasterKeyMissing() {
System.setProperty(EnvConfigUtils.CONFIG_KEEPASS_ENABLED_KEY, "true");
final EnvConfigException exception = Assertions.assertThrows(EnvConfigException.class,
() -> EnvConfig.get(PROPERTY_KEEPASS));
Assertions.assertEquals(String.format("Missing required variable '%s'", EnvConfigUtils.CONFIG_KEEPASS_MASTERKEY_KEY),
exception.getMessage());
Assertions.assertEquals(String.format("Missing required variable '%s'", "env.config.keepass.masterkey"),
exception.getMessage());
}

@Test
Expand Down