chore: update ruff in pre commit #130
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 What needed to be done and why?
I noticed that the ruff pre-commit was pointing to the old repo org and seemed quite out of date. So I updated it.
In the process, I noticed that we may not be matching the flake8 checks that I believe ruff was supposed to replace.
According to the configuration docs here, only a few "E" and all the "F" rules are in the default config, but not the "W" and not the Macabe stuff that are default in flake8.
I just added all the "E" and "W" rules.
I tested on a freshly generated project and these new ruff rules pass successfully.
🆕 What is changed by this PR?
📋 Code Review Cheatsheet
What the reviewer should check