Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en_US.json #10212

Closed
wants to merge 1 commit into from
Closed

Update en_US.json #10212

wants to merge 1 commit into from

Conversation

OlZin
Copy link

@OlZin OlZin commented Jan 17, 2024

Hello,

  • I have translated the language pack from English to Russian,
  • after I added the translation file to the folder with the program "...\AppData\Local\Programs\SiYuan\resources\appearance\lang\ru_RU.json"
  • on the Settings /Appearance/Language selection the file is selected, the translation is correct
  • now the interface speaks Russian
  • the problem is that Notebooks in the Document Tree do not work:
  • at your request, I am sending a PR to your en_US.json
  • consider extending the language packs to the program,
  • Please commit to the dev branch
  • For contributing new features, please supplement and improve the corresponding user guide documents
  • For bug fixes, please describe the problem and solution via code comments
  • For text improvements (such as typos and wording adjustments), please submit directly

Hello,
- I have translated the language pack from English to Russian, 
- after I added the translation file to the folder with the program `"...\AppData\Local\Programs\SiYuan\resources\appearance\lang\ru_RU.json"`
- on the Settings /Appearance/Language selection the file is selected, the translation is correct
- now the interface speaks Russian
- the problem is that Notebooks in the Document Tree do not work:
	- the list does not open, you cannot select notes,
		- I wrote in more detail in the topic siyuan-note#10209
	- I do not know the reason  
- at your request, I am sending a PR to your _en_US.json_
- consider extending the language packs to the program,
@github-actions github-actions bot changed the base branch from master to dev January 17, 2024 16:58
Copy link

Your PR was set to target master, PRs should be target dev
The base branch of this PR has been automatically changed to dev, please check that there are no merge conflicts

@88250
Copy link
Member

88250 commented Jan 18, 2024

Please create a new file ru_RU.json.

@zxhd863943427
Copy link
Contributor

Wait, I seem to have observed the wrong point before, you mean you can't expand the document in the document tree after using RU translation?

@OlZin
Copy link
Author

OlZin commented Jan 19, 2024

Please create a new file ru_RU.json.

I have attached the file in this message
#10209 (comment)

@OlZin
Copy link
Author

OlZin commented Jan 19, 2024

Wait, I seem to have observed the wrong point before, you mean you can't expand the document in the document tree after using RU translation?

The discussion branches are different. This one is 10212, the one you're talking about is 10209. I do not know how it happened.

@88250
Copy link
Member

88250 commented Jan 19, 2024

Please create a new file ru_RU.json.

I have attached the file in this message #10209 (comment)

Hello, please create and commit the ru_RU.json file, and do not modify en_US.json, otherwise we will not be able to merge this PR.

OlZin added a commit to OlZin/siyuan that referenced this pull request Jan 21, 2024
This is a package for the Russian language:
Request
siyuan-note#10212 (comment)
Thread with pull request
siyuan-note#10212
Primary topic sentence
siyuan-note#10209
@88250
Copy link
Member

88250 commented Feb 5, 2024

It has been on hold for too long, so we have closed it first. If it is convenient, please PR again if it is convenient. Thank you.

@88250 88250 closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants