Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

改进引述块样式和高亮样式、改进列表样式 #13143

Merged
merged 4 commits into from
Nov 14, 2024
Merged

改进引述块样式和高亮样式、改进列表样式 #13143

merged 4 commits into from
Nov 14, 2024

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Nov 13, 2024 •
edited
Loading

  1. 引述块的左边框不需要圆角、让高亮覆盖引述块的左边框（参考了其他产品）
  2. 让子列表块的高亮与其他块的高亮对齐 fix 改进选中子列表块的高亮 #11891

image

image

@Vanessa219 Vanessa219 merged commit 4ef73e6 into siyuan-note:dev Nov 14, 2024
2 checks passed
@TCOTC TCOTC deleted the dev-block-style branch November 14, 2024 03:42
Vanessa219 added a commit that referenced this pull request Nov 14, 2024
@Vanessa219
🎨 #13143
eb52775
Vanessa219 added a commit that referenced this pull request Nov 14, 2024
@Vanessa219
🎨 #13143
902ee81
@Vanessa219 Vanessa219 self-requested a review November 14, 2024 04:19
@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 14, 2024 •
edited
Loading

用伪元素的话我感觉对自定义了 ::before 样式的用户不太友好。

再加上高亮的 ::after ，两个伪元素都被用掉了。

Vanessa219 added a commit that referenced this pull request Nov 14, 2024
@Vanessa219
🎨 #13143
0a49a07
@Vanessa219
Copy link
Member

没有关系，css 可以重置的。现在这样更好看呀。

@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 16, 2024

@Vanessa219 样式在集市里有问题：

image

Vanessa219 added a commit that referenced this pull request Nov 17, 2024
@Vanessa219
🎨 #13143
1982ce6
@TCOTC
Copy link
Contributor Author

TCOTC commented Nov 19, 2024 •
edited
Loading

@Vanessa219 这个的位置也错了：

image

也需要一个 position: relative; ：

image

Vanessa219 added a commit that referenced this pull request Nov 19, 2024
@Vanessa219
🎨 #13143
1087fe8
@TCOTC TCOTC changed the title 改进引述块样式和高亮样式 改进引述块样式和高亮样式、改进列表样式 Nov 20, 2024
EightDoor added a commit to EightDoor/siyuan that referenced this pull request Nov 22, 2024
@EightDoor
Merge commit '928c1d476a4b398bdee3752cc950aed85838bf8f'
e7d57be 
* commit '928c1d476a4b398bdee3752cc950aed85838bf8f': (148 commits)
  🔖 Release v3.1.13
  🐛 Automatic cleanup of the local data repo may accidentally delete snapshots siyuan-note#13203
  🎨 Add internal kernel API `/api/sqlite/flushTransaction` siyuan-note#10005
  🐛 Automatic cleanup of the local data repo may accidentally delete snapshots siyuan-note#13203
  🎨 删除块，嵌入块中没有同步删除
  💄
  🔖 Release v3.1.12
  ⬆️ eslint
  🎨 Improve graph rendering siyuan-note#13196
  🎨 siyuan-note#13143
  🎨 siyuan-note#13190
  📝 Update changelogs
  ⬆️
  🎨 Improve av option editing siyuan-note#11484
  🎨 siyuan-note#13164
  🎨 Support HarmonyOS NEXT system siyuan-note#13184
  🎨 siyuan-note#11053
  🚨
  🎨 siyuan-note#11053
  🎨 Support HarmonyOS NEXT system siyuan-note#13184
  ...
@TCOTC TCOTC mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vanessa219 Vanessa219 Awaiting requested review from Vanessa219

Assignees

@Vanessa219 Vanessa219

@TCOTC TCOTC

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TCOTC @Vanessa219