Improve `Recent documents` #15824

Achuan-2 · 2025-09-10T23:57:41Z

关联：#11189

Pull Request Overview

This PR improves the Recent Documents functionality by introducing time-based tracking and sorting options. The main goal is to make recently viewed documents more accessible by changing from tab-load-order to actual view-time sorting, and providing multiple sort options for document organization.

Key Changes

Added three timestamp fields (viewedAt, closedAt, openAt) to track document interaction times
Implemented a dropdown in the Recent Documents dialog supporting sort by: Recently Viewed, Recently Modified, Recently Opened, and Recently Closed
Added Ctrl+Shift+T keyboard shortcut to reopen recently closed documents, replacing table insertion shortcuts

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
kernel/model/storage.go	Added timestamp fields to RecentDoc struct and implemented update/sort functions for view/open/close times
kernel/api/storage.go	Added API endpoints for updating document timestamps and modified getRecentDocs to accept sort parameter
kernel/api/router.go	Registered new API routes for timestamp updates
app/src/business/openRecentDocs.ts	Implemented sort dropdown UI and SQL query for "Recently Modified" option
app/src/layout/Wnd.ts	Added timestamp tracking when tabs are focused/added/closed and closedTabs array management
app/src/editor/util.ts	Added view time update when opening files
app/src/mobile/editor.ts	Added view time update for mobile file opening
app/src/mobile/menu/getRecentDocs.ts	Updated to request viewedAt sorting
app/src/boot/globalEvent/keydown.ts	Implemented Ctrl+Shift+T handler to reopen closed tabs
app/src/constants.ts	Removed default shortcuts for table row/column insertion
app/appearance/langs/*.json	Added translations for new sort options in all supported languages

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

kernel/model/storage.go

Copilot · 2025-10-24T03:34:16Z

app/src/business/openRecentDocs.ts

+        const sortSelect = dialog.element.querySelector("#recentDocsSort") as HTMLSelectElement;
+        sortSelect.addEventListener("change", () => {


The variable 'sortSelect' is referenced before it is declared. Line 125 uses 'sortSelect.value' but the element is not queried until line 146. Move the querySelector for sortSelect to before line 125 where it's first used.

Copilot · 2025-10-24T03:34:16Z

app/src/layout/Wnd.ts

+                    }
+                    (window as any).siyuan.closedTabs.push({
+                        id: item.model.editor.protyle.block.rootID
+                    });


Consider limiting the size of the closedTabs array to prevent unbounded memory growth. Implement a maximum size (e.g., 50) and remove oldest entries when the limit is reached.

Suggested change

});

});

// Limit closedTabs array size to 50 to prevent unbounded memory growth

if ((window as any).siyuan.closedTabs.length > 50) {

(window as any).siyuan.closedTabs.shift();

}

Copilot · 2025-10-24T03:34:16Z

app/src/boot/globalEvent/keydown.ts

+            openFileById({
+                app,
+                id: closedTab.id,
+                action: [Constants.CB_GET_FOCUS, Constants.CB_GET_SCROLL]
+            });


No error handling is provided when reopening a closed tab fails (e.g., if the document was deleted). Add error handling to notify users when a document cannot be reopened.

Suggested change

openFileById({

app,

id: closedTab.id,

action: [Constants.CB_GET_FOCUS, Constants.CB_GET_SCROLL]

});

try {

const result = openFileById({

app,

id: closedTab.id,

action: [Constants.CB_GET_FOCUS, Constants.CB_GET_SCROLL]

});

if (result && typeof result.then === "function") {

result.catch((error: any) => {

Dialog.create({

title: "无法重新打开标签",

content: "该文档无法重新打开，可能已被删除或移动。",

});

});

}

} catch (error) {

Dialog.create({

title: "无法重新打开标签",

content: "该文档无法重新打开，可能已被删除或移动。",

});

}

Copilot · 2025-10-24T03:34:16Z

app/appearance/langs/ja_JP.json

  "wysiwyg": "WYSIWYG",
+  "recentViewed": "最近閲覧",
+  "recentOpened": "最近開いた",
+  "recentClosed": "最近閉じる",


Corrected Japanese translation from '最近閉じる' (infinitive form) to '最近閉じた' (past tense) to match the context of 'recently closed'.

Suggested change

"recentClosed": "最近閉じる",

"recentClosed": "最近閉じた",

Signed-off-by: Daniel <[email protected]>

TCOTC · 2025-10-25T09:55:51Z

01

这里需要持久化：

video.webm

TCOTC · 2025-10-25T11:43:10Z

02

在移动端需要支持切换显示“最近浏览”和“最近修改”

TCOTC · 2025-10-25T12:05:17Z

03

使用了快速制卡、更换了文档图标、更换了题头图、修改了块属性……的文档没有添加到“最近修改”中，这符合预期吗？

TCOTC · 2025-10-25T12:10:41Z

04

需要支持配置最近的文档的显示数量。

有时候会突然需要打开一个昨天关闭的文档，Ctrl+E 之后发现已经被今天的文档顶掉了，希望能显示更多数量。
Improve Recent documents #11189 (comment)

Vanessa219 · 2025-10-25T13:14:21Z

Done
移动端最近文档改进 #16198
03 更新使用的是 sql 后台查数据 @88250 核对一下是否可以改进
配置项先不加了

88250 · 2025-10-25T13:35:30Z

03 更新时间获取的是 updated 字段，制卡、给图标、题头图不会更新 updated 字段，这个就不动了，符合预期。

Achuan-2 added 7 commits September 11, 2025 07:56

✨ Improve Recent documents

e25913f

基于文档最近浏览时间进行排序

✨ 支持显示最近关闭文档

fea231f

✨ 支持显示最近关闭文档

84964f0

✨ 支持显示最近关闭文档

cac0028

✨ 支持显示最近关闭文档

661c6cf

✨ 支持显示最近关闭文档

d619152

✨ 支持显示最近关闭文档

39758c7

✨支持Ctrl+Shift+T打开最近关闭的文档

b1a1777

Achuan-2 added 2 commits September 11, 2025 10:27

🎨 clean code

27c2929

🔥 移除表格插入行/列的默认快捷键

b3b7286

This comment was marked as outdated.

Sign in to view

Achuan-2 added 3 commits September 11, 2025 11:33

✨ 最近文档支持显示最近修改文档

bc2447b

🎨

4285d10

✨ 最近文档支持查看最近打开

814e78d

Achuan-2 changed the title ~~✨ Improve Recent documents~~ Improve Recent documents Sep 11, 2025

Achuan-2 added 3 commits September 12, 2025 00:01

🎨

68cb063

⏪

eeabbaf

Merge branch 'dev' into recentDocImprove

e10078e

Achuan-2 mentioned this pull request Sep 19, 2025

Improve Recent documents Achuan-2/siyuan#5

Closed

Update win-build.bat

acc8ca4

88250 changed the title ~~Improve Recent documents~~ Improve Recent documents Oct 4, 2025

88250 mentioned this pull request Oct 4, 2025

Improve Recent documents #11189

Closed

88250 added the Enhancement label Oct 4, 2025

88250 added this to the backlog milestone Oct 4, 2025

Merge branch 'dev' into recentDocImprove

202c3b1

Vanessa219 mentioned this pull request Oct 24, 2025

Support Ctrl+Shift+T to reopen the tab #11205

Closed

88250 modified the milestones: backlog, 3.3.6 Oct 24, 2025

Vanessa219 merged commit d9e0c56 into siyuan-note:dev Oct 24, 2025

Vanessa219 requested review from 88250, Vanessa219 and Copilot October 24, 2025 03:32

Vanessa219 self-assigned this Oct 24, 2025

Copilot AI reviewed Oct 24, 2025

View reviewed changes

Vanessa219 added a commit that referenced this pull request Oct 24, 2025

🎨 #11205 & #15824

ec6e7a0

88250 added a commit that referenced this pull request Oct 24, 2025

🎨 Improve Recent documents #15824

994bdc0

Signed-off-by: Daniel <[email protected]>

Vanessa219 added a commit that referenced this pull request Oct 24, 2025

🎨 #15824

5ec6b31

Vanessa219 added a commit that referenced this pull request Oct 24, 2025

🎨 #15824

918f679

Vanessa219 added a commit that referenced this pull request Oct 24, 2025

♻️ #15824

7eb6bcd

Vanessa219 added a commit that referenced this pull request Oct 24, 2025

♻️ #15824

e2815eb

Vanessa219 mentioned this pull request Oct 25, 2025

移动端最近文档改进 #16198

Open

Vanessa219 added a commit that referenced this pull request Oct 25, 2025

🎨 #15824

f89ef1b

		const sortSelect = dialog.element.querySelector("#recentDocsSort") as HTMLSelectElement;
		sortSelect.addEventListener("change", () => {

-                    });
+                    });
+                    // Limit closedTabs array size to 50 to prevent unbounded memory growth
+                    if ((window as any).siyuan.closedTabs.length > 50) {
+                        (window as any).siyuan.closedTabs.shift();
+                    }

-            openFileById({
-                app,
-                id: closedTab.id,
-                action: [Constants.CB_GET_FOCUS, Constants.CB_GET_SCROLL]
-            });
+            try {
+                const result = openFileById({
+                    app,
+                    id: closedTab.id,
+                    action: [Constants.CB_GET_FOCUS, Constants.CB_GET_SCROLL]
+                });
+                if (result && typeof result.then === "function") {
+                    result.catch((error: any) => {
+                        Dialog.create({
+                            title: "无法重新打开标签",
+                            content: "该文档无法重新打开，可能已被删除或移动。",
+                        });
+                    });
+                }
+            } catch (error) {
+                Dialog.create({
+                    title: "无法重新打开标签",
+                    content: "该文档无法重新打开，可能已被删除或移动。",
+                });
+            }

	"recentClosed": "最近閉じる",
	"recentClosed": "最近閉じた",

Uh oh!

Improve Recent documents #15824

Improve Recent documents #15824

Conversation

Achuan-2 commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wish5115 commented Sep 11, 2025

Uh oh!

TCOTC commented Sep 11, 2025

Uh oh!

Achuan-2 commented Sep 11, 2025

Uh oh!

Achuan-2 commented Sep 11, 2025

Uh oh!

wish5115 commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

wish5115 commented Sep 11, 2025

Uh oh!

Achuan-2 commented Sep 11, 2025

Uh oh!

Achuan-2 commented Sep 11, 2025

Uh oh!

TCOTC commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vanessa219 commented Oct 24, 2025

Uh oh!

TCOTC commented Oct 24, 2025

Uh oh!

88250 commented Oct 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

TCOTC commented Oct 25, 2025

01

Uh oh!

TCOTC commented Oct 25, 2025

02

Uh oh!

TCOTC commented Oct 25, 2025

03

Uh oh!

TCOTC commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

04

Uh oh!

Vanessa219 commented Oct 25, 2025 • edited by 88250 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

88250 commented Oct 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Improve `Recent documents` #15824

Improve `Recent documents` #15824

Achuan-2 commented Sep 10, 2025 •

edited

Loading

wish5115 commented Sep 11, 2025 •

edited

Loading

TCOTC commented Oct 8, 2025 •

edited

Loading

TCOTC commented Oct 25, 2025 •

edited

Loading

Vanessa219 commented Oct 25, 2025 •

edited by 88250

Loading