-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the sticky layout of Attribute View #9625
Improve the sticky layout of Attribute View #9625
Conversation
… view the height of the breadcrumbs caused the first and last rows to misalign in attribute view
|
…h in attribute view
修复调整可换行的列宽时尾行位置错位问题 |
固定列已完整实现,目前冲突较多,先关闭了。 |
别关闭啊, 我兼容一下 |
@Vanessa219 已解决冲突且完成兼容, 并进行了本地测试 |
是要提交什么么? |
可以重新打开该 PR, 拉取一下该分支编译测试一下, 目前没发现什么问题嘿嘿 |
明早要发版了,目前先不动了。 上次看代码有点多,和原有设计也有冲突。最新的是修复了什么问题? |
不用急
|
分成不同的 PR 吧,这样不会因为其他问题导致全部都无法合并。我也比较好 review,否则 merge 了出现问题又需要 revert 了。 这样发布公告也比较清晰,每个 issue 是做了什么。代码追踪也比较好做一点。 |
可以, 但是最好都尽快合并, 我没有精力同时维护太多的 PR |
|
.av__firstcol
元素上层添加.av__sticky
元素, 以便于钉住多列Add a '.av__sticky' element on top of the '.av__firstcol' element to make it easier to pin multiple columns
30px
时属性视图首行与尾行类粘性布局错位问题30px
TESTED