Also check REDIRECT_REMOTE_USER for remote auth#190
Open
neil-sabol wants to merge 2 commits intosjarvela:masterfrom
neil-sabol:master
Open
Also check REDIRECT_REMOTE_USER for remote auth#190neil-sabol wants to merge 2 commits intosjarvela:masterfrom neil-sabol:master
neil-sabol wants to merge 2 commits intosjarvela:masterfrom
neil-sabol:master
Conversation
Check REDIRECT_REMOTE_USER in addition to REMOTE_USER for remote authentication. REMOTE_USER still takes precedence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Samuli,
Hope all is well on your end.
This is a very basic enhancement - let me know your thoughts/feedback. Some webservers populate REDIRECT_REMOTE_USER for remote authentication (instead of REMOTE_USER). This proposed change in Authentication.class.php builds upon your logic to check REDIRECT_REMOTE_USER as well.
Let me know.
Thank you for all of your efforts on Kloudspeaker - this is a phenomenal project.
Best,
-Neil