Conversation
Add documentation for the PermissionRequest hook event which was missing from the skill despite being in the official Claude Code documentation. PermissionRequest runs when a permission dialog is shown and allows hooks to automatically allow or deny permission requests. Changes: - Add PermissionRequest to skill description event list - Add PermissionRequest section in Hook Events with example and output format - Add PermissionRequest to Quick Reference table - Add PermissionRequest to event-specific fields documentation - Add PermissionRequest to validate-hook-schema.sh VALID_EVENTS array Fixes #67 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
7 tasks
|
Claude finished @sjnims's task —— View job PR Review Complete ✅
SummaryLooks good - ready to merge ✅ This PR successfully addresses issue #67 by adding comprehensive documentation for the What's GoodExcellent consistency and completeness:
Well-structured commit:
Technical DetailsThe changes align perfectly with the repository's conventions from CLAUDE.md:
Checklist Verification
Recommendation: Approve and merge. This is a straightforward documentation addition that fills a gap in the hook-development skill documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Fixes #67
The hook-development skill was missing documentation for PermissionRequest, which is a valid hook event in the official Claude Code documentation. This caused:
Solution
Added comprehensive documentation for PermissionRequest:
Alternatives Considered
Changes
plugins/plugin-dev/skills/hook-development/SKILL.md: Added PermissionRequest documentation (+50 lines)plugins/plugin-dev/skills/hook-development/scripts/validate-hook-schema.sh: Added PermissionRequest to VALID_EVENTSTesting
🤖 Generated with Claude Code