Skip to content

docs(hook-development): add PermissionRequest hook event documentation#69

Merged
sjnims merged 1 commit intomainfrom
docs/67-add-permissionrequest-hook-event
Dec 9, 2025
Merged

docs(hook-development): add PermissionRequest hook event documentation#69
sjnims merged 1 commit intomainfrom
docs/67-add-permissionrequest-hook-event

Conversation

@sjnims
Copy link
Copy Markdown
Owner

@sjnims sjnims commented Dec 8, 2025

Summary

  • Added documentation for the PermissionRequest hook event
  • Updated validate-hook-schema.sh to recognize PermissionRequest as a valid event
  • PermissionRequest allows automatic allow/deny of permission dialogs

Problem

Fixes #67

The hook-development skill was missing documentation for PermissionRequest, which is a valid hook event in the official Claude Code documentation. This caused:

  1. Users not knowing about this capability
  2. The validation script incorrectly warning about PermissionRequest being unknown

Solution

Added comprehensive documentation for PermissionRequest:

  • New section in Hook Events with example configuration and output format
  • Added to skill description trigger list
  • Added to Quick Reference table
  • Added to event-specific input fields
  • Added to VALID_EVENTS in validate-hook-schema.sh

Alternatives Considered

  • Document as "not supported for plugins": Rejected because official docs show it's available
  • Minimal one-line addition: Rejected because consistent documentation requires the same treatment as other events

Changes

  • plugins/plugin-dev/skills/hook-development/SKILL.md: Added PermissionRequest documentation (+50 lines)
  • plugins/plugin-dev/skills/hook-development/scripts/validate-hook-schema.sh: Added PermissionRequest to VALID_EVENTS

Testing

  • Markdownlint passes
  • Shellcheck shows only pre-existing warnings (not related to this change)
  • Documentation follows existing patterns

🤖 Generated with Claude Code

Add documentation for the PermissionRequest hook event which was missing
from the skill despite being in the official Claude Code documentation.
PermissionRequest runs when a permission dialog is shown and allows hooks
to automatically allow or deny permission requests.

Changes:
- Add PermissionRequest to skill description event list
- Add PermissionRequest section in Hook Events with example and output format
- Add PermissionRequest to Quick Reference table
- Add PermissionRequest to event-specific fields documentation
- Add PermissionRequest to validate-hook-schema.sh VALID_EVENTS array

Fixes #67

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
Copy link
Copy Markdown

claude bot commented Dec 8, 2025

Claude finished @sjnims's task —— View job


PR Review Complete ✅

  • Gather context and read repository conventions
  • Get PR diff to see exact changes
  • Read changed files
  • Run markdownlint on changed .md files
  • Review against plugin-dev criteria
  • Post final review feedback

Summary

Looks good - ready to merge

This PR successfully addresses issue #67 by adding comprehensive documentation for the PermissionRequest hook event, which was missing from the hook-development skill despite being a valid event in the official Claude Code documentation.

What's Good

Excellent consistency and completeness:

  • Perfect formatting: Markdownlint passes with no issues
  • Follows existing patterns: The PermissionRequest documentation matches the structure and style of other hook events (PreToolUse, PostToolUse, Stop) exactly
  • Comprehensive coverage: Added to all relevant locations:
    • Skill description trigger list (line 3)
    • New dedicated section with example and output format (lines 162-208)
    • Quick Reference table (line 647)
    • Event-specific input fields documentation (line 378)
    • Validation script VALID_EVENTS array
  • Clear documentation: Includes practical example, complete output format specification, field explanations, and use cases
  • Proper validation update: The validate-hook-schema.sh script now correctly recognizes PermissionRequest as valid

Well-structured commit:

Technical Details

The changes align perfectly with the repository's conventions from CLAUDE.md:

  1. Skill structure: Maintains the progressive disclosure pattern with core content in SKILL.md
  2. Writing style: Uses imperative form in the body ("Execute when...", "Use to...") and includes trigger phrases in the description
  3. Documentation pattern: Follows the same structure as other hook events:
    • Brief description
    • Example configuration
    • Output format with detailed field explanations
    • Use cases

Checklist Verification

Recommendation: Approve and merge. This is a straightforward documentation addition that fills a gap in the hook-development skill documentation.


@sjnims sjnims self-assigned this Dec 8, 2025
@claude claude bot added documentation Improvements or additions to documentation component:skill Skills layer effort:small < 1 hour labels Dec 8, 2025
@sjnims sjnims merged commit 94aa984 into main Dec 9, 2025
8 checks passed
@sjnims sjnims deleted the docs/67-add-permissionrequest-hook-event branch December 9, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:skill Skills layer documentation Improvements or additions to documentation effort:small < 1 hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs]: Document or clarify PermissionRequest hook event status for plugins

1 participant